Problems with core review

[Warren Togami]

Roozbeh Pournader wrote:
> I have been trying to help with the core review, and I wish to share the
> major burdens I encountered:
> 
> 1) Online CVS access is not available to reviewers. There is a delay of
> about two hours, I believe. Packager says "I fixed it", reviewer says
> "did you not forget to commit, because I don't see it"?

I agree this is a problem, but not one that we can solve easily.  This 
problem is already scheduled to go away in the near future when the CVS 
move happens.  Can we just deal for now and focus on the tougher problems?

> 
> 2) Core package owners may not be very familiar with the packaging
> guidelines, or why they are actually there. Some may even think it's
> just some level of bureaucracy/extra burden (in short, not very
> exciting).

They need to just deal with it.  If they haven't heard about the 
packaging guidelines by now, they are not doing their job properly and 
they need some education.

/me prepares the cluebat.

> 
> 3) Core package owners were not asked to clean up their packages before
> putting them up for review. Packages have been sitting there and then
> suddenly a horde of odd and demanding people have jumped on to review
> them. This also means that the quality of what being reviewed is quite
> random, when a quick look at the guidelines (and doing some related
> action) may have minimized the extra communication and the possibility
> of reviewers burning out because of repeating the same basic things
> instead of finding/fixing the more interesting issues.
> 
> 4) The process is not very clear. Packagers have fixed some of the
> mentioned issues and change the status to MODIFIED, packagers have fixed
> some of the mentioned issues and change the status to FIXED/RAWHIDE, ...
> But I assume that's getting fixed.

This needs to be addressed in the next version of the process.  I think 
the states like MODIFIED, CLOSED RAWHIDE, should become irrelevant. 
What matters is the fedora-review+ flag, and if it happened properly or not.

Warren