Adding a note to the package review guidelines

[Patrice Dumas]

On Fri, Jun 08, 2007 at 07:54:40PM +1200, Nigel Jones wrote:
> >> "Potential reviewers are encouraged to please check that the
> >> reportee/submitter of a review request is current in the cvsextras package
> >> group before commencing a review"

> I'm aware of the sponsor process, I wonder if you caught the small bit
> in brackets "(of course, this wouldn't apply to people that could
> sponsor someone)".

Ah, ok I missed it.
 
> FE-NEEDSPONSOR is a good idea in theory, but it doesn't always work,
> people make honest mistakes in forgetting to add it other packages they
> put in for review, or they are not aware they need to do this.  Checking
> against fedoracvs by general maintainers is the only foolproof way.

Indeed.

> In which case, the packages are not normally assigned to the person who
> is providing a pre-review, I'm only suggesting placing a note in the top
> of the review guidelines reminding people to check that the person that
> is asking for a review has already been granted fedoracvs before
> performing a review and granting the fedora-review flag.

Ok, this makes sense. Should say no assign and no grant, but may do an
informal review. My fear was that non-sponsors would think they can't do
an informal review.

--
Pat