[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Missing PAGE_MASK macro on PPC arches



On Mon, 2007-06-25 at 16:24 +0400, Dmitry Butskoy wrote:
> The macro "PAGE_MASK" is normally defined in the "asm/page.h" header, 
> provided  by the "kernel-headers" package. This header is auto-generated 
> from the correspond "include/asm-powerpc/page.h", with removing of all 
> "__KERNEL__" ifdefs.
> 
> Unlike in x86, the "PAGE_MASK" definition in 
> "include/asm-powerpc/page.h" is kernel-private (i.e. sits under the 
> "__KERNEL__" ifdef), hence after the stripping we have an empty 
> "asm/page.h" for ppc and ppc64 arches.

> Because of this some programs are not compiled properly.

Anything relying on PAGE_SIZE or PAGE_MASK in <asm/page.h> is broken.
Userspace should be using getpagesize() instead.

> Is it an upstream kernel bug or something else?

It could be considered a kernel bug that we do actually expose our
private parts on i386. We should probably fix that.

-- 
dwmw2


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]