Missing PAGE_MASK macro on PPC arches
Balint Cristian
cbalint at redhat.com
Mon Jun 25 14:03:12 UTC 2007
> fbtv (Frame Buffer TV) from xawtv package.
> > It's likely not a bug. PowerPC can have 4KiB or 64KiB pages, and
> > PAGE_MASK is dependent upon the kernel config option being set one way
> > or another since it's derived from PAGE_SHIFT.
> >
>
> Yep, we just should use getpagesize() for now.
I agree. But what about binutils than ?
../../bfd/trad-core.c:117: error: 'PAGE_SIZE' undeclared (first use in this function)
^^^
this seems that binutils rely on all arches on page.h exported PAGE_SIZE ?
I have same problem on alpha, only one arch (till now) wich page.h doesnt export
PAGE_SIZE, so i used to move PAGE_SIZE out of kernel pragma space like:
cat ../SOURCES/linux-2.6.21-alpha_pagesize.patch
--- linux/include/asm-alpha/page.h.orig 2007-06-25 00:19:41.000000000 +0200
+++ linux/include/asm-alpha/page.h 2007-06-25 00:21:46.000000000 +0200
@@ -1,15 +1,15 @@
#ifndef _ALPHA_PAGE_H
#define _ALPHA_PAGE_H
-#ifdef __KERNEL__
-
-#include <asm/pal.h>
-
/* PAGE_SHIFT determines the page size */
#define PAGE_SHIFT 13
#define PAGE_SIZE (1UL << PAGE_SHIFT)
#define PAGE_MASK (~(PAGE_SIZE-1))
+#ifdef __KERNEL__
+
+#include <asm/pal.h>
+
#ifndef __ASSEMBLY__
#define STRICT_MM_TYPECHECKS
/chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/fedora-maintainers/attachments/20070625/a0f6ebce/attachment.sig>
More information about the Fedora-maintainers
mailing list