[Bug 188946] Review Request: contacts
bugzilla at redhat.com
bugzilla at redhat.com
Thu Apr 13 21:17:26 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: contacts
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188946
jkeating at redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|bugzilla-sink at leemhuis.info |jkeating at redhat.com
OtherBugsDependingO|163776 |163778
nThis| |
------- Additional Comments From jkeating at redhat.com 2006-04-13 17:17 EST -------
So, a few things going on here in the spec that should be looked at:
- Source url should not use macros
- PreReq seems a bit odd, why the Pre and the regular Req?
- Use of defines at the top seems a bit much. Why define it to use it in only
one place? (one place if you don't hard specify Requires)
- Hard specified Requires, rpm should be able to figure this out on its own
- Graphical app but no .desktop file
- Files section is referencing directories rather than files within directories.
Other than that its a good start (;
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list