[Bug 180747] Review Request: powerman

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: powerman


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180747





------- Additional Comments From woodard at redhat.com  2006-04-21 21:01 EST -------
Finally had some time to work on this.

I fixed the problem with the mock build and uploaded a new set of packages.

With regards to the other problems. I believe you must have been looking at an
older version of the spec file.

There are no errors or warnings coming from rpmlint:

[ben at flix result]$ pwd
/var/lib/mock/fedora-development-i386-core/result
[ben at flix result]$ rpmlint powerman-*
[ben at flix result]$

Defattr is set to (-,root,root):

[ben at flix result]$ grep defattr /tmp/powerman.spec
%defattr(-,root,root)
- changed defattr which was interfering with perms of included files.
[ben at flix result]$

There are no places where we have hard coded /etc and we are using _sysconfdir:

[ben at flix result]$ grep etc /tmp/powerman.spec
- change perms on files in etc/powerman so that they don't look like scripts
- changed etc to sysconfdir macro.
- Changed /etc/rc.d/init.d/ to initrddir
[ben at flix result]$ grep sysconf /tmp/powerman.spec
chmod 644 $RPM_BUILD_ROOT/%{_sysconfdir}/powerman/*
%dir %{_sysconfdir}/powerman
%config(noreplace) %{_sysconfdir}/powerman/*
- changed etc to sysconfdir macro.
[ben at flix result]$

Will you please reevaluate the CURRENT version of powerman's SRPM.

http://dl.sourceforge.net/sourceforge/powerman/powerman.spec
http://dl.sourceforge.net/sourceforge/powerman/powerman-1.0.23-4.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.