[Bug 189690] Review Request: swh-plugins

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: swh-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189690


bdpepple at ameritech.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From bdpepple at ameritech.net  2006-04-23 15:31 EST -------
PUBLISH +1

MD5Sums:
1d8418b85034ee9153c726c4c7188a1a  swh-plugins-0.4.14.tar.gz

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All directories are owned by this or other packages
* All necessary BuildRequires listed.
* All desired features are enabled
* Builds fine in Mock.
* Package installs and uninstalls cleanly on FC4.

Notes:
* rpmlint gives the following, which are fairly self-explanatory to fix:
  W: swh-plugins summary-ended-with-dot A set of audio plugins for LADSPA.
  E: swh-plugins zero-length /usr/share/doc/swh-plugins-0.4.14/NEWS
* The BuildRequirements for pkgconfig, gettext, libtool, bison, and
perl-XML-Parser are unnecessary since Mock should pulls these in the minimum
chroot. 
* Don't package the INSTALL doc, since it's the generic GNU Autotools file.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.