[Bug 189717] Review Request: gcompris - Educational suite for kids 2-10 years old

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcompris - Educational suite for kids 2-10 years old


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189717


wart at kobold.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From wart at kobold.org  2006-04-30 03:12 EST -------
rpmlint output:
E: gcompris hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/menu

- This is a bogus warning.  rpmlint is complaining about the src
  rpm without realizing that this file is being removed, not included.

W: gcompris-devel no-dependency-on gcompris

- This is ok by design.  -devel requires -libs so that it doesn't
  need to pull in rather large (and unnecessary) base package.

W: gcompris-devel no-documentation
W: gcompris-libs no-documentation

- This can be ignored.  The developers documentation is integrated with
  the base package's documentation.

W: gcompris-flags no-documentation
W: gcompris-sound-da no-documentation
W: gcompris-sound-de no-documentation
W: gcompris-sound-en no-documentation
W: gcompris-sound-es no-documentation
W: gcompris-sound-eu no-documentation
W: gcompris-sound-fi no-documentation
W: gcompris-sound-fr no-documentation
W: gcompris-sound-hu no-documentation
W: gcompris-sound-it no-documentation
W: gcompris-sound-nl no-documentation
W: gcompris-sound-pt no-documentation
W: gcompris-sound-ru no-documentation
W: gcompris-sound-sv no-documentation

- These can be ignored.  There's no need for documentation for localized
  sound/flag files.


MUST
====
 * GPL license ok, license file included
 * Package and spec file named appropriately
 * Spec file legible and in Am. English (except for the localized parts)
 * Sources for the review came from upstream:
   d80e55da21170a98d671c98b3e582cc3  SOURCES/gcompris-7.4.tar.gz
 * Builds in mock on devel-i386, devel-x86_64
 * Locales handled appropriately
 * ldconfig called for shared libs in -libs subpackage
 * Not relocatable
 * Owns directories that it creates
 * No duplicate %files
 * Contains code and permissible content
 * $RPM_BUILD_ROOT cleaned correctly in %install and %clean
 * File permissions appear to be ok
 * headers, .so, and pkgconfig files in -devel
 * -devel requires -libs, not base (this is acceptable, see above)
 * .la files not included
 * .desktop files installed correctly
 * No need for -doc subpackage

SHOULD
=========
 * Consider adding Requires: tuxpaint for the tuxpaint launcher

I did a quick check of the english/german sounds on a handful of the games and
it worked with no obvious problems.

No blockers found.

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.