[Bug 184331] Review Request: K-3D - 3D modeling and rendering system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: K-3D - 3D modeling and rendering system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184331





------- Additional Comments From denis at poolshark.org  2006-08-07 17:46 EST -------
Spec: http://www.poolshark.org/src/k3d.spec
SRPM: http://www.poolshark.org/src/k3d-0.5.16.0-1.src.rpm

Paul, thanks for your patience and for your comments. I was able to borrow a
build system and do a little more testing, and I also exchanged a few emails
with upstream developers. Comments embedded below.

> --mode 644  : Is this required for the desktop icon?

No, about 5% of extras packages specify it explicitely. I removed it.

> E: k3d devel-dependency k3d-devel

Ok, I checked with upstream and the good news is that this requirement can be
dropped (they updated the wiki to clarify). So this is fixed.

> Also has the devel-file-in-non-devel warnings

Those are false positives, as confirmed by upstream:

Timothy M. Shead <tshead at k-3d.com> Wrote:
"The .h files in /share/shaders are part of the shader source code, not
the K-3D source code.  They are there so that shaders can be compiled
*at runtime* by the user's RenderMan engine.  So they belong in the
runtime package."

> E debuginfo script-without-shellbang
> /usr/src/debug/k3d-0.5.15.0/k3dsdk/nodes.cpp (as an example)

Fixed.

> The devel package contains a pile of warnings about 
> dangling-relative-symlinks

Right, this occurs when a  package uses library symlinks in a subdirectory of
/usr/lib (those in /usr/lib are ignored by rpmlint). For example, 'graphviz' is
another package that has the same problem. Anyways, this actually was an error
in the spec as the run-time package requires the .so files, so I had to move
them into the main package. K-3D will not load the plugins correctly if only the
.so.0.0.0 files are present. There are a couple of libs in /usr/lib that also
need their .so files in the main package, because they are dlopened directly by
k3d-bin. I think those really belong in /usr/lib/k3d and I've reported the
problem upstream, a fix would require a pretty intrusive autoconf/automake patch
which i think is not worth the effort.

> E: k3d-devel only-non-binary-in-usr-lib

Should no longer occur, as /usr/lib/k3d is in the main package now.

Should build cleanly in mock, for devel and FC-5. FC-4 requires a small BR
change, but otherwise also builds cleanly.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.