[Bug 201418] Review Request: widelands - GPL Settlers II clone

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: widelands - GPL Settlers II clone


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201418


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
OtherBugsDependingO|163776                      |163778, 177841
              nThis|                            |




------- Additional Comments From j.w.r.degoede at hhs.nl  2006-08-10 16:40 EST -------
MUST:
=====
* rpmlint output is:
E: widelands description-line-too-long Your objective is not to send hordes of
warriors to destroy a enemy, but to build a strong economy.
E: widelands description-line-too-long Your objective is not to send hordes of
warriors to destroy a enemy, but to build a strong economy.
W: widelands no-documentation
E: widelands version-control-internal-file
/usr/share/widelands/tribes/empire/buildings/lumberjack/CVS/Root
E: widelands version-control-internal-file
/usr/share/widelands/worlds/greenland/bobs/tree1/CVS/Repository
E: widelands version-control-internal-file
/usr/share/widelands/tribes/barbarians/buildings/tavern/CVS/Tag
E: widelands version-control-internal-file
/usr/share/widelands/tribes/barbarians/buildings/deep_oremine/CVS/Entries
E: widelands version-control-internal-file
/usr/share/widelands/worlds/blackland/bobs/pebble6/CVS/Root
E: widelands version-control-internal-file
/usr/share/widelands/worlds/greenland/bobs/tree1/CVS/Tag
E: widelands version-control-internal-file
/usr/share/widelands/tribes/barbarians/buildings/warmill/CVS/Repository
And then tons more og the "version-control-internal-file" errors.
These must all be fixed.
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License (GPL) ok, license file included
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel-x86_64
* BR: ok
* No locales
* No shared libraries
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code and permissible content
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* no -devel package needed, no libs / .la files.
* .desktop file as required and properly installed

MUST FIX:
=========
* During build desktop-file-install gives this message:
  widelands.desktop: missing encoding  (guessed UTF-8)
* rpmlint output:
E: widelands description-line-too-long Your objective is not to send hordes of
warriors to destroy a enemy, but to build a strong economy.
E: widelands description-line-too-long Your objective is not to send hordes of
warriors to destroy a enemy, but to build a strong economy.
W: widelands no-documentation
E: widelands version-control-internal-file
/usr/share/widelands/tribes/empire/buildings/lumberjack/CVS/Root
E: widelands version-control-internal-file
/usr/share/widelands/worlds/greenland/bobs/tree1/CVS/Repository
E: widelands version-control-internal-file
/usr/share/widelands/tribes/barbarians/buildings/tavern/CVS/Tag
E: widelands version-control-internal-file
/usr/share/widelands/tribes/barbarians/buildings/deep_oremine/CVS/Entries
E: widelands version-control-internal-file
/usr/share/widelands/worlds/blackland/bobs/pebble6/CVS/Root
E: widelands version-control-internal-file
/usr/share/widelands/worlds/greenland/bobs/tree1/CVS/Tag
E: widelands version-control-internal-file
/usr/share/widelands/tribes/barbarians/buildings/warmill/CVS/Repository
And then tons more og the "version-control-internal-file" errors.
These must all be fixed. Hint for the version-control-internal-file" errors do a 
rm -fr `find -name CVS` on your CVS co before creating the tarbal, this way you
get a substantial smaller tarbal too.
* Drop the "A Settlers II OpenSource clone. " from the summary, this may be
  inspired by Settlers II bu advertising it as a clone is asking for legal 
  trouble.
* As already said don't put the desktop file into a tarbal, just refer to it
  directly. Also don't copy it to the build-dir instead just refer to it as
  %{SOURCE1} in the desktop-file-install command.
* Remove the bogus "#make %{?_smp_mflags}" line from the spec, this package
  uses sconstruct, so that line makes no sense at all.
* There ARE usuable docs, for example the COPYING file and probably others too.
* Please add an icon file according to the freedesktop.org icon standard, it
  should go under:
  %{_datadir}/icons/hicolor/32x32/apps
  Where 32x32 is the size of the icon, please do ls /usr/share/icons/hicolor/
  to see the available valid sizes, if the icon doesn't match any pick the 
  closest. 
* Once the icon is in the proper place you must add %post(un) script to update 
  the icon-cache see:
http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d836b77c3428619c689d
* RPM_OPT_FLAGS do not get used during the build, good luck with fixing this as
  this can be a bitch with SConstruct builds, let me know if you need any help 
  with this.

Questions
=========
* Why the build=debug?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.