[Bug 196749] Review Request: php-pecl-xdebug - PECL package for debugging PHP scripts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-xdebug - PECL package for debugging PHP scripts
Alias: php-pecl-xdebug

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196749





------- Additional Comments From tibbs at math.uh.edu  2006-08-11 00:49 EST -------
This builds fine; rpmlint just has this to say:

W: php-pecl-xdebug setup-not-quiet

which is no big deal but it's true that there's little point in showing the full
tar output when unpacking the source.  Pass "-q" to %setup to quiet both tar and
rpmlint.

We settled on the following macro definitions:
%global php_apiver  %((echo 0; php -i 2>/dev/null | sed -n 's/^PHP API => //p')
| tail -1)
%global php_extdir  %(php-config --extension-dir 2>/dev/null || echo "undefined")
can you switch things over to using those?

I'm not sure it's a good idea to require a minimum php-api; you'd almost
certainly require a rebuild if the API changes, so wouldn't you need to require
a specific php-api?  Also, there's not much point in requiring a specific PHP
version as even FC1 had PHP 4.3.4; you have to go back to RH9 to find something
older.

Other than those bits, everything looks pretty good.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.