[Bug 202439] Review Request: frozen-bubble - Frozen Bubble arcade gam

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: frozen-bubble - Frozen Bubble arcade gam


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202439





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-08-16 00:47 EST -------
(In reply to comment #5)
> 
> MUSTFIX
> =======
> * BR: perl is not necessary.  It is already picked up by perl-SDL.
> 
Ok, will fix as soon as we've got agreement on the things below

> SHOULD
> ======
> * There is some inconsistency in the use of $RPM_BUILD_ROOT vs.
>   ${RPM_BUILD_ROOT}.  Both work.  Pick one and stick with it.
> 
Agree, thats because I didn't do the original specfile I'll make it all
$RPM_BUILD_ROOT

> * The perl autoprovider in rpm adds some automatic provides since this package
>   installs files into %{perl_vendorarch}.  If these files are only going
>   to be used by frozen-bubble, wouldn't it be better to put them somewhere
>   in %{_datadir}/frozen-bubble instead?

Erm, there are .so files installed to %{perl_vendorarch}, hence the package is
not noarch. I could try dropping them in %{_libdir}/frozen-bubble instead, but
I've got no clue howto make perl find them there (first perl package ever for me).

Or we could just leave them there :) (in which case I could add a provides
filter to make it stop providing this if you want).


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.