[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
bugzilla at redhat.com
bugzilla at redhat.com
Wed Aug 16 08:27:12 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gcin - Chinese input method server for Traditional Chinese
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337
mtasaka at ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtasaka at ioa.s.u-tokyo.ac.jp
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2006-08-16 04:17 EST -------
Hello.
--------------------------------------------------------
Again I have to mention that I cannot sponsor you formally
because I am not a member of sponsors.
You may ask on fedora-extras mailing lists for someone to
sponsor you.
--------------------------------------------------------
I see lots of rpmlint complaints were removed.
mock builds cleanly.
Then:
* rpmlint:
gcin-1.2.1-3.i386.rpm:
E: gcin script-without-shellbang /etc/X11/xinit/xinput.d/gcin
--- I suspect the permission of /etc/X11/xinit/xinput.d/gcin
can be 0644 (see /etc/X11/xinit/xinput.d/scim.conf in scim).
gcin-1.2.1-3.src.rpm:
W: gcin strange-permission gcin 0755
--- change the permission of gcin (source 1) to 0644
gcin-debuginfo-1.2.1-3.i386.rpm:
gcin-devel-1.2.1-3.i386.rpm:
W: gcin-devel no-soname /usr/lib/libgcin-im-client.so
--- This is unwilling, however, this is a problem of this
package, not your packaging. You may tell upstream that
a proper soname should be added or you can add a soname
by yourself for a moment.
By the way, can this file be in devel package, not in
main package? (I don't know well about gcin......)
* debuginfo rpm is of no use.
This is because this package....
A. does not accept CFLAGS. i.e. This package is not built with
debug option "-g". Overwrite OPTFLAGS like
-----------------------------------------------------------------
in %build stage:
make OPTFLAGS="${RPM_OPT_FLAGS}" %{?_smp_mflags}
-----------------------------------------------------------------
B. This package strips binaries, which is not accepted for fedora
packages. Fix makefile not to strip binaries, like
-----------------------------------------------------------------
in %prep stage:
sed -i.strip -e 's|install[ \t][ \t]*-s|install|' Makefile
-----------------------------------------------------------------
With fix by A and B: rpmlint complains:
W: gcin non-conffile-in-etc /etc/X11/xinit/xinput.d/gcin
-- can be ignored, I think
W: gcin-devel no-soname /usr/lib/libgcin-im-client.so
-- you may ask upstream to fix this.
E: gcin-devel shlib-with-non-pic-code /usr/lib/libgcin-im-client.so
-- I don't know well about shared libraries, however, this
error means:
The listed shared libraries contain object code that was compiled
without -fPIC. All object code in shared libraries should be
recompiled separately from the static libraries with the -fPIC option.
Another common mistake that causes this problem is linking with
``gcc -Wl,-shared'' instead of ``gcc -shared''.
--- libgcin-im-client.so is made by gcin-im-client.o im-addr.o gcin-conf.o
util.o gcin-crypt.o and actually gcin-crypt.o is not compiled with
-fpic. gcin-crypt.o is used to make another binary and in this case,
gcin-crypt.o should be compiled without -fpic. So I think gcin-crypt.c
must be compiled twice with different ways. Fix this.
For example:
-----------------------------------------------------------------
--- gcin-1.2.1/im-client/Makefile.orig 2006-05-01 18:57:43.000000000 +0900
+++ gcin-1.2.1/im-client/Makefile 2006-08-16 16:55:01.000000000 +0900
@@ -6,7 +6,7 @@
-DCLIENT_LIB=1 -DGCIN_BIN_DIR=\"$(GCIN_BIN_DIR)\" \
-DDEBUG="0$(GCIN_DEBUG)" -DGCIN_TABLE_DIR=\"$(GCIN_TABLE_DIR)\" \
-DFREEBSD=$(FREEBSD)
-OBJS = gcin-im-client.o im-addr.o gcin-conf.o util.o gcin-crypt.o
+OBJS = gcin-im-client.o im-addr.o gcin-conf.o util.o gcin-crypt-fpic.o
.c.E:
$(CC) $(CFLAGS) -E -o $@ $<
@@ -43,6 +43,9 @@
im-addr.o: ../im-srv/im-addr.c
$(CC) -c -fpic $(CFLAGS) -o $@ $<
+gcin-crypt-fpic.o: gcin-crypt.c
+ $(CC) -c -fpic $(CFLAGS) -o $@ $<
+
clean:
rm -f *.o *.so *~ *.E *.db config.mak tags core.* .depend
-------------------------------------------------------------------
E: gcin-debuginfo script-without-shellbang
/usr/src/debug/gcin-1.2.1/IMdkit/include/IMdkit.h
E: gcin-debuginfo script-without-shellbang
/usr/src/debug/gcin-1.2.1/IMdkit/include/Xi18n.h
E: gcin-debuginfo script-without-shellbang
/usr/src/debug/gcin-1.2.1/IMdkit/include/XimProto.h
--- fix this with:
-------------------------------------------------------------------
in %prep stage:
find . -name \*.h -o -name \*.c | xargs chmod ugo-x
-------------------------------------------------------------------
* %post and %postun
Require something to execute %post (and %postun) properly.
e.g. Requires(post): /usr/sbin/alternatives, chkconfig
* Requires:
Requires: gtk2 >= 2.2.4 atk cairo glib2 pango
All of these are not needed because gcin requires
libgtk-x11-2.0.so.0 libatk-1.0.so.0 libglib-2.0.so.0 libpango-1.0.so.0 and
these libraries require the package above. So explicit requirements of
those above are unnecessary.
* Again:
Check files which this package should have. I suspect that this
package should own %{_datadir}/gcin/
The file entry contains:
-------------------------------------------------------------------
%{_datadir}/gcin/*
-------------------------------------------------------------------
I think that this must be
-------------------------------------------------------------------
%{_datadir}/gcin/
-------------------------------------------------------------------
, which includes the files under /usr/share/gcin AND the directory
/usr/share/gcin .
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list