[Bug 191017] Review Request: eclipse-subclipse

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-subclipse


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191017


robert at marcanoonline.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED




------- Additional Comments From robert at marcanoonline.com  2006-08-22 00:00 EST -------
Updated:

http://www.marcanoonline.com/downloads/fedora/package_submissions/subclipse/eclipse-subclipse-1.1.5-1.fc6.src.rpm
http://www.marcanoonline.com/downloads/fedora/package_submissions/subclipse/eclipse-subclipse.spec

> W: eclipse-subclipse patch-not-applied Patch10:
> eclipse-subclipse-1.1.4-plugin-classpath.patch
>   Not sure what's up here; perhaps a comment as to why this isn't applied would
> help.

comment added and it was changed to a %Source tag, this patch is applied at
install time, not at the "prep" stage

> W: eclipse-subclipse no-documentation
>  Indeed, there's nothing marked as %doc.  Is there anything that should be so
> marked?  There are license files as plain text and HTML changelog files and
> such, which seems like they qualify.

I added the svnClientAdapter related readme.txt and changelog.txt, subclipse
uses eclipse help system, and it is packages the same way that eclipse-cdt (no
documentation)

> W: eclipse-subclipse symlink-should-be-relative
>
/usr/share/eclipse/plugins/org.tigris.subversion.subclipse.core_1.1.4/lib/javasvn.jar
> /usr/share/java/javasvn.jar
>  However, the link should be relative.

All eclipse related RPMs package dependencies as absolute links, i just did the
same.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.