[Bug 203217] Review Request: csound - music synthesis system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: csound - music synthesis system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203217





------- Additional Comments From dcbw at redhat.com  2006-08-24 17:20 EST -------
(In reply to comment #7)
> I'm a tad concerned that it's redefining printf for some reason in a HELL of a
> lot of files. It seems to be coming from h/csoundCore.h line 119

I asked about that, upstream is now aware that we dislike it :)  It was added to
make sure that all plugins use the Csound logging facilities.  I think it may go
away in the near future, and we can likely remove it if we wish.

> 
> rpmlint warnings.
> 
> src.rpm is clean
> 
> csound-5.03.0-2 : W: csound no-soname %{_libdir}/lib_csnd.so (should this not be
> in the -devel package?

No, it's the python module code, and it should be in
/usr/lib/python2.4/site-packages/.  I'll move it.

> csound-devel : W: csound-devel no-docs (can be ignored)
> 
> csound-python: W: dangling-symlink %{_libdir}/python2.4/site-packages/_csnd.so
> %{_libdir}/lib_csnd.so
> csound-python: W: symlink-should-be-relative
> %{_libdir}/python2.4/site-packages/_csnd.so %{_libdir}/lib_csnd.so

Will be fixed when that lib moves to python's site-packages.
 
> csound-java: W: no-soname %{_libdir}/lib_jsound.so
>              W: no-docs
>              W: symlink-should-be-relative %{_datadir}/java/csnd.jar
> %{_libdir}/csound/java/csnd.jar

This one shouldn't be a symlink either, should probably move csnd.jar to
%{_datadir} too.

> csound-tk: E: only-non-binary-in-usr-lib
>            W: no docs
> 
> csound-debuginfo: clean
> 
> For the missing .so files, these really should be in the csound-devel package
> (and java-devel package). The tk Error must be attended to.

Except that most aren't devel libs; they are the java and python module
libraries and should live in those packages, not in the main csound packages.

> 
> Your specfile is also missing Requires(post and postun): /sbin/ldconfig

Will add.

> Does the package not come with other vocabulary languages? If this is for the
> OLPC programme, then it makes sense for translations to be in there!

I don't think so...  I couldn't see a switch for it at build-time, but I'll ask.

> In %files...
> 
> The %{_bindir} entries can be globbed to make things easier to read (or better
> still, a simple for loop on the package names.

Can that be done even if some stuff from %{_bindir} is owned by a sub-package?

> In %files devel
> %{_includedir}/%{name}/* Need to be changed to %{includedir}/%{name}/ to take
> ownership of the directory and files

Will do.

> In %files tk
> 
> I'm not sure about the .tk files in %{_libdir}. Is this the correct place for
them?

Yeah, that's odd.  I'm not sure.

> csound is currently building in mock - I'll report back when it's done.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.