[Bug 202457] Review Request: crack-attack - Puzzle action game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: crack-attack - Puzzle action game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202457





------- Additional Comments From packages at amiga-hardware.com  2006-08-27 10:40 EST -------
* rpmlint: no problems
* Package named correctly: Yes
* Patches named correctly: Yes
* Spec file named correctly: Yes
* Licence field matches: Yes
* Licence file installed: Yes (and included upstream)
* Spec file in American English: Yes
* Source matches upstream: Yes
* Locales use %find_lang: N/A
* Contains %clean: Yes
* Specfile legible: Yes
* Compiles and builds ok: Yes (mock: fc5/ppc)
* Calls ldconfig in %post/%postun for shlibs: N/A
* Owns directories it creates: Yes
* Duplicate files: No
* Permissions set correctly: Yes
* Consistent macro use: Yes (but see suggestion)
* %doc affects runtime: No
* Headers and static libs in -devel: N/A
* .pc files in -devel: N/A
* .so in -devel: N/A
* -devel requires base: N/A
* Contains .la files: No
* Owns files it didn't create: No
* .desktop files installed correctly: Yes


1. The URL: tag appears to point to an old site, as the latest version on this 
site is 1.1.10 and the source location is different. I feel http://
www.nongnu.org/crack-attack/ would be a better choice.

2. No use of %{name}-%{version} macros in Source tag. Personal preference but 
just a heads up if you prefer to use them.

3. Several files are installed in the %doc directory which probably shouldn't 
be there:

*.sanitize: The patch backup files
crack-attack.6: An uncompressed copy of the man page, but the man page is 
correctly installed in %{_mandir}/man6/
crack-attack.xml: Really a 'source' file for generating the man page so I 
wouldn't install it.
ready_to_release: Useless to the end user IMHO and shouldn't be installed.

4. /usr/share/crack-attack/crack-attack.desktop and /usr/share/crack-attack/
crack-attack.xpm, do these files really need to be there?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.