[Bug 202457] Review Request: crack-attack - Puzzle action game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: crack-attack - Puzzle action game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202457


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora-games-list at redhat.com




------- Additional Comments From j.w.r.degoede at hhs.nl  2006-08-27 16:00 EST -------
Everybody / anybody I'm cc-ing fedora-games-list as it looks like this package
is going to be reviewed if you have any doubts, really any at all about the
legal status of this package please speak up now, before it gets approved,
imported and build!

(In reply to comment #7)
> 1. The URL: tag appears to point to an old site, as the latest version on this 
> site is 1.1.10 and the source location is different. I feel http://
> www.nongnu.org/crack-attack/ would be a better choice.
> 
Fixed

> 2. No use of %{name}-%{version} macros in Source tag. Personal preference but 
> just a heads up if you prefer to use them.
> 
Missed those in the old specfile I inhereted, fixed.

> 3. Several files are installed in the %doc directory which probably shouldn't 
> be there:
> 
> *.sanitize: The patch backup files
> crack-attack.6: An uncompressed copy of the man page, but the man page is 
> correctly installed in %{_mandir}/man6/
> crack-attack.xml: Really a 'source' file for generating the man page so I 
> wouldn't install it.
> ready_to_release: Useless to the end user IMHO and shouldn't be installed.
> 

Woops, fixed, thanks!

> 4. /usr/share/crack-attack/crack-attack.desktop and /usr/share/crack-attack/
> crack-attack.xpm, do these files really need to be there?

The .xpm is needed and I've used the .desktop as the .desktop and installed it
with --delete-original.

New version with all this fixed here:
Spec URL: http://people.atrpms.net/~hdegoede/crack-attack.spec
SRPM URL: http://people.atrpms.net/~hdegoede/crack-attack-1.1.14-8.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.