[Bug 204343] Review Request: qcomicbook - a comic book viewing program

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qcomicbook - a comic book viewing program


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204343





------- Additional Comments From bdpepple at ameritech.net  2006-08-28 13:28 EST -------
Couple of quick items (note this is not an official review):

1. Desktop file is not handled correctly.  Refer to
http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755
2. In the build section you should use 'make %{?_smp_mflags}' instead of '%{__make}'
3. The Requires on qt & imlib2 are unnecessary since the sonames on the devel
packages will pull these in.
4. You should use 'rm -rf $RPM_BUILD_ROOT' instead of '[ "$RPM_BUILD_ROOT" !=
"/" ] && rm -rf "$RPM_BUILD_ROOT"' in your spec.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.