[Bug 212925] Review Request: php-pear-Structures-DataGrid-DataSource-RSS - DataSource driver using RSS files
bugzilla at redhat.com
bugzilla at redhat.com
Sat Dec 2 20:22:50 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Structures-DataGrid-DataSource-RSS - DataSource driver using RSS files
Alias: pear-DG-RSS
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212925
tibbs at math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From tibbs at math.uh.edu 2006-12-02 15:22 EST -------
Another single file PHP package, with the standard rpmlint warnings:
W: php-pear-Structures-DataGrid-DataSource-RSS no-documentation
W: php-pear-Structures-DataGrid-DataSource-RSS filename-too-long-for-joliet
php-pear-Structures-DataGrid-DataSource-RSS-0.1.0-1.fc7.noarch.rpm
I note that all of these DataSource-* packages have ended up owning
/usr/share/pear/Structures/DataGrid/DataSource
Have you condidered the possibility of php-pear-Structures-DataGrid owning that
directory?
* source files match upstream:
cdde39675c40e059281b5a727df23d8a Structures_DataGrid_DataSource_RSS-0.1.0.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible. License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
O rpmlint output is OK.
* final provides and requires are sane:
php-pear(Structures_DataGrid_DataSource_RSS) = 0.1.0
php-pear-Structures-DataGrid-DataSource-RSS = 0.1.0-1.fc7
=
/bin/sh
/usr/bin/pear
php-pear(PEAR)
php-pear(Structures_DataGrid_DataSource_Array)
php-pear(XML_RSS)
* %check is not present; no test suite is upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list