[Bug 218408] Review Request: xl2tpd - replacement of l2tpd

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xl2tpd - replacement of l2tpd


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218408


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-12-05 07:09 EST -------
Well, again full review of this package.

A. From http://fedoraproject.org/wiki/Packaging/Guidelines :
* rpmlint:
- rpmlint output is not silent.
-----------------------------------------------------
1. E: xl2tpd non-readable /etc/xl2tpd/l2tp-secrets 0600
2. E: xl2tpd non-readable /etc/ppp/chap-secrets.sample 0600
3. W: xl2tpd dangerous-command-in-%post mv
4. E: xl2tpd no-chkconfig-line /etc/rc.d/init.d/xl2tpd
-----------------------------------------------------
1. 2. : I don't know well about this package, however,
        please check if the permisson of these files are
        correct.
3. : I think that this warnings may ignorable, however:
     * By the way which is done first, doing %post scriptlet
       of xl2tpd, or obsoleting (i.e. deleting) xl2tpd?
       I vaguely remember several case (by yum) that
       obsoleting a package is done _before_ installing
       a substitute rpm.

       I think moving or copying should be done by 
       %triggerun
4. : This error can be suppressed by replacing tab with space
     in '# chkconfig:    - 80 30' line.

* Timestamps
- Use 'install -p' to keep timestamps.
  And I recommend that Makefile should be also fixed to
  use 'install -p'.

B. http://fedoraproject.org/wiki/Packaging/ScriptletSnippets :
* Initscripts Conventions
  - Please add the appropriate requirement in
    Requires(post), etc.

C. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
   (Okay).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.