[Bug 217197] Review Request: MyBashBurn 1.0-1 - burn data and songs.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn 1.0-1 - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217197





------- Additional Comments From wilmer at fedoraproject.org  2006-12-06 01:42 EST -------
(In reply to comment #11)
> > %post
> > ln -s %{_datadir}/%{name}/MyBashBurn.sh %{_bindir}/mybashburn > /dev/null 2>&1
> > ln -s %{_datadir}/%{name}/MyBashBurn.sh %{_bindir}/bashburn > /dev/null 2>&1
> > 
> > %postun
> > rm -f %{_bindir}/bashburn
> > rm -f %{_bindir}/mybashburn
> 
> Why? This is extremely ugly. The files are not even %ghosted. They
> are not tracked in the RPM database. Why not simply create these links
> at build-time and include them in the package? That is the way it ought
> to be.

yeah, It sound kickass, better and more appropriate, I've added it in build-time.
 
> > %files
> > %defattr(-,root,root,0755)
> > %{_datadir}/%{name}/*
> 
> Directory %{_datadir}/%{name} is not included. Correct would be:
> 
> %{_datadir}/%{name}/
> 

Unknown that the contents would be recursive, now the directory trailing use is
fixed.
 
> > %doc COPYING CREDITS ChangeLog FAQ FILES HOWTO INSTALL README TODO
> 
> Is the "INSTALL" file the typical NLS documentation which is irrelevant
> to users of your RPM package? If so, don't include it. It is confusing.

Exactly. INSTALL file not is appropiate for users except for possible developers
of MyBashBurn only, it content "troubleshooting" section and installation's
instruction for tar file, neverthless, just i exclude the INSTALL file. Fixed.

> > install -d %{buildroot}/usr/lib/debug
> 
> What's this?

Really i don't know, i think that may be strictly needed for %build section, if
ommited it to get the next error:
find: /var/tmp/mybashburn-1.0-1-root-k0k/usr/lib/debug: No such file or directory

If create the directory %{buildroot}/usr/lib/debug issue fixed.
Please, remember that this package is a couple of ShellScripts written to make
cd burning in the console easier, just not is a program written in C/C++ or some
similar, for this i can't see why must be include %build section for this package?.
 
> Further, prefer "install" with option -p  (or "cp" with option -p)
> to preserve timestamps wherever it is possible.

Okay. I should adjusted the install -p for which components: files or
directories or both?

Please let me know what more i need to do, Thanks in advance for your response.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.