[Bug 174377] Review Request: gnu-smalltalk - GNU Smalltalk

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnu-smalltalk - GNU Smalltalk


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174377





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-12-06 09:34 EST -------
Well, again reviewing this package:

>From http://fedoraproject.org/wiki/Packaging/Guidelines :

* Requires:
- automake requirement
  Well, that I wrote that 'automake' is needed for Requires
  is for -devel package, not -emacs package, because
  -devel package includes .m4 files, while -emacs packages 
  does not.
- pkgconfig requirement
  This is also for -devel package.  

* Timestamps
- Keeping timestamps is not treated completely.
--------------------------------------------------------------
make  install-data-hook
make[3]: Entering directory `/builddir/build/BUILD/smalltalk-2.3'
rm -f /var/tmp/gnu-smalltalk-2.3-root-mockbuild/usr/share/gnu-smalltalk/packages.xml
./gst-package --srcdir="." --no-load
--destdir="/var/tmp/gnu-smalltalk-2.3-root-mockbuild" packages.xml
Merging  packages.xml into
/var/tmp/gnu-smalltalk-2.3-root-mockbuild/usr/share/gnu-smalltalk/packages.xml...
mkdir /var/tmp/gnu-smalltalk-2.3-root-mockbuild/usr/share/gnu-smalltalk/browser
/usr/bin/install -c -m 644 browser/test.st
/var/tmp/gnu-smalltalk-2.3-root-mockbuild/usr/share/gnu-smalltalk/browser/test.st
/usr/bin/install -c -m 644 browser/ChangeLog
/var/tmp/gnu-smalltalk-2.3-root-mockbuild/usr/share/gnu-smalltalk/browser/Chang
eLog
mkdir /var/tmp/gnu-smalltalk-2.3-root-mockbuild/usr/share/gnu-smalltalk/gtk
/usr/bin/install -c -m 644 gtk/Structs.st
/var/tmp/gnu-smalltalk-2.3-root-mockbuild/usr/share/gnu-smalltalk/gtk/Structs.st
/usr/bin/install -c -m 644 gtk/Enums.st
/var/tmp/gnu-smalltalk-2.3-root-mockbuild/usr/share/gnu-smalltalk/gtk/Enums.st
/usr/bin/install -c -m 644 gtk/Funcs.st
/var/tmp/gnu-smalltalk-2.3-root-mockbuild/usr/share/gnu-smalltalk/gtk/Funcs.st
......
--------------------------------------------------------------
  Here 'install -c' is used, not 'install -c -p'.
  This is due to './gst-package' content. Fix this file so that
  timestamps are correctly kept.

  Umm.. I think that this file is a bit strange and somewhat
  incorrect.
  Why does this file echo:
-----------------------------------------------------------------
echo "/usr/bin/install -c -m 755 $file $dest"
-----------------------------------------------------------------
  which prints out 'install' but actually do:
-----------------------------------------------------------------
$dry_run || (rm -f "$dest" && cp "$file" "$dest" && chmod 755 "$dest")
-----------------------------------------------------------------
  not using install but using cp? This script is wrong when
  when we set @INSTALL@ environment to others such as 'install -p'
  (which I strongly recommend) by
---------------------------------------------------------------
export INSTALL='install -p'
%configure ....
---------------------------------------------------------------
  This case gst-package prints out the message as if this script
  keep timestamps (by 'install -p') , while the actual behaviour 
  of this file is not to keep timestamps (by executing 'cp').

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.