[Bug 207202] Review Request: bes - Back-end server software framework for OPeNDAP

bugzilla at redhat.com bugzilla at redhat.com
Fri Dec 8 22:09:00 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bes - Back-end server software framework for OPeNDAP


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207202


bjohnson at symetrix.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163776
              nThis|                            |




------- Additional Comments From bjohnson at symetrix.com  2006-12-08 17:08 EST -------
I am providing you a review, but I do not have a contributor account (no
sponsor), so I can't assign the bug to myself.

rpmlint is quiet on all files
mock-build FC6 is successful

MUST Items:
- MUST: The License field in the package spec file must match the actual license.

I did not see the license in the source file or on the website.  A review of one
of the source files seems to indicate that it is LGPL.  This would not be
considered "bsd-like".  Please work with upstream on getting the LGPL license
document included in the source file, and then add it to the %doc section.

I think you have a well put together package.  If you have the facilities, in
the future try to mock-build your packages first as that will tend to weed out
the missing BuildRequires.

Do continue to pursue upstream regarding any build issues (broken autotools
etc.) or dependency bloat.

This ends my review.  Flipping you back to FE-NEW so that you can have a
sponsored reviewer make an official review.

 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list