[Bug 219036] Review Request: perl-Roman - Roman module from CPAN
bugzilla at redhat.com
bugzilla at redhat.com
Sun Dec 10 15:55:33 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Roman - Roman module from CPAN
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219036
jpo at di.uminho.pt changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776 |163778
nThis| |
------- Additional Comments From jpo at di.uminho.pt 2006-12-10 10:55 EST -------
NEEDSWORK
MD5SUMS:
3bcd42265a01a9261b18146273872a0d perl-Roman-1.1-0.fc.1.src.rpm
0ded0e59e44267c803c4c8609ee52523 perl-Roman.spec
67b0e6affdc50fdf28cfc438c045fd9b Roman-1.1.tar.gz
Sources:
* Roman-1.1.tar.gz: MD5 digest matches the CPAN tarball
NeedsWork:
* wrong release (and dist tag)
* the license information is incomplete: perl is dual licensed
(GPL or Artistic)
* changelog entry missing
* remove the dot at the end of the summary (rpmlint)
Suggestions:
* change the URL to "http://search.cpan.org/dist/Roman/"
(no author or version info - easier to maintain)
* the perl build requirement can be dropped
* when copying files try to preserve the timestamps
(use install with the -p option)
* you can also use install to create the perl directory
(%{__install} -d -m 0755 $RPM_BUILD_ROOT%{perl_vendorlib})
* don't mix spaces and tabs in the specfile
(check the release line)
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list