[Bug 218258] Review Request: audacious-docklet - a docklet plugin for Audacious

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: audacious-docklet - a docklet plugin for Audacious


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218258


fedora at christoph-wickert.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: <audacious- |Review Request: audacious-
                   |docklet> - <a docklet plugin|docklet - a docklet plugin
                   |for Audacious>              |for Audacious
                 CC|                            |fedora at christoph-wickert.de
OtherBugsDependingO|                            |177841
              nThis|                            |




------- Additional Comments From fedora at christoph-wickert.de  2006-12-11 18:40 EST -------
Adding the FE-NEEDSPONSOR tracker.

Some initial comments on you specfile:

- please don't use %define rel and ver.

- don't repeat the name of the package in Summary, just use "A docklet plugin
for Audacious".

- the release tag is wrong, should be "1%{?dist}", which will result in 
audacious-docklet-0.1.1-1.fc6.src.rpm. Please read
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-5ea39bbc33cf351b41b51325ac3527eff4c58dac
and 
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-beca3bf84972f19a384cc2e5091ed47c2b3cebc7

- BuildRoot should be
"%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)", see 
http://fedoraproject.org/wiki/Packaging/Guidelines#head-f196e7b2477c2f5dd97ef64e8eacddfb517f1aa1

- no BuildRequires are certainly not correct

- %description should be more elaborate while it's only the summary again. You
should describe the features of the program a little.

- remove the link to the website from %description, rpm has it's own tag "URL"
for that, which is missing in your specfile.

- linking to http://nedudu.hu/?page_id=11 is a bad idea, for it's not a
permanent link. In a feew weeks this will be on page 12 and so on. The permalink
for this entry is http://nedudu.hu/index.php?entry=entry060828-105151, but I
suggest you use http://nedudu.hu/static.php?page=audacious instead.

So you would insert
"URL: http://nedudu.hu/static.php?page=audacious" somewhere, e. g. below License:

- simplyfy the %clean section to "rm -rf $RPM_BUILD_ROOT"

- you should clean the built-root at the beginning of %install, too:
  %install
  rm -rf $RPM_BUILD_ROOT
  make DESTDIR=$RPM_BUILD_ROOT install

- %defattr should be (-,root,root,-)

- remove INSTALL and ABOUT-NLS from %doc, not needed if the programm is
installed via rpm

- the %files is not ok, simply using %{_datadir} will result in directories
which are owned by multiple packages.

- locales need to be handled with %find_lang, see
http://fedoraproject.org/wiki/Packaging/Guidelines#head-8c605ebf8330f6d505f384e671986fa99a8f72ee

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.