[Bug 217197] Review Request: MyBashBurn 1.0-1 - burn data and songs.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn 1.0-1 - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217197





------- Additional Comments From bugs.michael at gmx.net  2006-12-12 04:43 EST -------
> E: mybashburn world-writable /etc/mybashburnrc 0666
> ---> Note that this is good and is necessary for the package,
>  see comment #3

Are you kidding? Files in /etc must not be writable by ordinary
users. The software is flawed, if there is no implementation of
user-local configuration files in $HOME.

> %{buildroot}/usr/lib/debug

Then your RPM config or installation is broken. You don't need to
create that directory.

> mybashburn conffile-without-noreplace-flag /etc/mybashburnrc

This refers to

  %config(noreplace) /etc/mybashburnrc

which influences RPM's strategy for *.rpmsave/*.rpmnew config files.

> E: mybashburn script-without-shebang

This is a hint about all the executable files which should not be
executable. Take a close look at "rpm --query --list mybashburn" and
notice the questionable file permissions.

The manual page is executable, too. And so are many other files which
need not be executable.

> E: mybashburn standard-dir-owned-by-package /usr/bin

List the files included in your package:
rpm --query --list --verbose mybashburn

You include the directory /usr/bin which is wrong, since it belongs into
the core "filesystem" package already.

> E: mybashburn wrong-script-end-of-line-encoding
> /usr/share/mybashburn/lang/Polish/multi.lang
> 
> --> WTF?.

There are DOS/Windows-style 0x0d 0x0a (carriage return, linefeed) line
delimiters used in that file instead of just 0x0a (linefeed). Should be
fixed upstream. Can be fixed with dos2unix or sed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.