[Bug 219025] Review Request: ntop - A network traffic probe similar to the UNIX top command

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ntop - A network traffic probe similar to the UNIX top command


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219025





------- Additional Comments From bjohnson at symetrix.com  2006-12-12 06:59 EST -------
(In reply to comment #16)
> * the autotools related patches should be made upstream (after removal
>   of fedora specific stuff). Did you contact them?

No, I want to make sure everything is working first.

> * tcp_wrappers-devel is out in devel

I will fix that in the next update.
 
> * rpmlint warnings seems to be ignorable.

I agree.
 
> * I reiterate that dlopened objects are better without version, I
>   think the current spec is right.

I agree.
 
> * ntop is still uninterruptible by Ctrl-C when the password is 
>   entered, but I guess it is because Ctrl-C is interpreted as a 
>   character of the password.

I believe that is true, but I'll look into it.

> * I still get, after ctrl-C for the first run:
> mar 12 déc 2006 12:07:28 CET  THREADMGMT[t3029126032]: RRD: Data collection
> thread terminated [p11257]
> *** glibc detected *** ntop: malloc(): memory corruption: 0x096121f0 ***
> ======= Backtrace: =========
> /lib/libc.so.6[0x2ff54b]
> /lib/libc.so.6(__libc_malloc+0x7e)[0x300c6e]
> /usr/lib/libntop-3.2.so(ntop_safestrdup+0x39)[0xb585c9]
> /usr/lib/libntop-3.2.so(traceEvent+0x312)[0xb7c472]
> /usr/lib/libntop-3.2.so(pcapDispatch+0x1d2)[0xb5ba02]
> /lib/libpthread.so.0[0x1532db]
> /lib/libc.so.6(clone+0x5e)[0x365eee]
> ======= Memory map: ========
> Abandon

I'm unable to reproduce this.  Try loading the debug symbols and getting a
backtrace under gdb.
 
> * Kevin made this relevant comment:
> 8. Instead of removing the .a files you could just pass '--disable-static'
> to configure. Possibly also enable: --enable-snmp ?

I'll include both of those in the next release.
 
> * I dislike the following in the init file:
> chown -f root.ntop /var/ntop/*db  > /dev/null 2>&1
> chmod -f 664 /var/ntop/*db  > /dev/null 2>&1
> 
> Is it really needed?

I dislike it too.  There are some non-trivial permission problems that we must
overcome.  I think another patch is in order because I just found a security
hole (the admin password file is created world readable).

> * when starting ntop with /etc/init.d/ntop start 
>   the [ OK ] doesn't appear.

Fixed for the next release.
 
> * the mechanism described in the "PRIVACY NOTICE" of the man
>   page should be disabled, at least when started from init file.
>   (the option may be in the ntp.conf file, for example).

I forgot about this, so I'll fix it in the next release.
 
> * ntop web server listens on all interfaces. In the default case 
>   it should only listen to localhost, with
> -w 127.0.0.1:3000

You're right, I'll change that in the init script and config file as well.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.