[Bug 220284] Review Request: bcfg2 - Configuration management client and server

bugzilla at redhat.com bugzilla at redhat.com
Wed Dec 20 13:15:00 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bcfg2 - Configuration management client and server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220284





------- Additional Comments From Axel.Thimm at ATrpms.net  2006-12-20 08:14 EST -------
Just for future reference rpmlint says

W: bcfg2 invalid-license BCFG Public License
E: bcfg2 wrong-line-in-lsb-tag #                    installs configuration files
served by bcfg2-server
E: bcfg2 wrong-line-in-lsb-tag #                    This is a client that
installs the server provided
E: bcfg2 wrong-line-in-lsb-tag #                    Configuration.
E: bcfg2 subsys-not-used /etc/rc.d/init.d/bcfg2
W: bcfg2-server invalid-license BCFG Public License
E: bcfg2-server wrong-line-in-lsb-tag #                    installs
configuration files served by bcfg2-server
E: bcfg2-server subsys-not-used /etc/rc.d/init.d/bcfg2-server

The wrong-line-in-lsb-tag is due to continuation of the Description fields. I'm
not sure whether rpmlint is wrong, or the init file. subsys-not-used: I wouldn't
had marked it as and error in rpmlint, but maybe it's not a bad idea to add it
to the init file.

rpm install is noisy, the openssl output should go to /dev/null. You need to
reverse the order of 2>&1 and /dev/null.

The file /etc/bcfg2.key is unowned. That's like for openssh's keys, but perhaps
not the best practice. Better own a dummy file, mark it as %config(noreplace),
and overwrite it on first install. The key would remain in the rpmdb as a
changed config file, so upgrades would not touch it and uninstalls would keep it
as *.rpmsave. This is just a (very) weak suggestion, though.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list