[Bug 220185] Review Request: kvm - Kernel Based Virtual Machine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kvm - Kernel Based Virtual Machine


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220185





------- Additional Comments From katzj at redhat.com  2006-12-20 10:36 EST -------
(In reply to comment #3)
> mock build for i386 successfull but rpmlint is not silent

rpmlint errors are bogus --
E: kvm configure-without-libdir-spec
   The configure script isn't a standard autoconf configure and so doesn't take
a libdir argument
W: kvm no-documentation
   Upstream doesn't really include any documentation in the tarball 
 
> You SHOULD:
>  - Add disttag {?dist} to release tag

disttag isn't required.

>  - Add direct download link of any mirror of sf.net
>   say http://jaist.dl.sourceforge.net/sourceforge/kvm/kvm-7.tar.gz

Fixed, but with the link from the other comment

>  - Add COPYRIGHT file under %doc 

There's not an explicit COPYRIGHT for the top-level and adding more copies of
the GPL to the distro doesn't help anyone.

>  - You may add test directory under %doc

This doesn't make any sense at all; tests aren't documentation.

(In reply to comment #6)
> IMHO, Either you need to submit KMOD package for kvm.ko for kernel versions
> lesser than 2.6.20 if this module supports existing FC6/devel kernels or  this
> package needs dependency to be set for kernel's > 2.6.20

The package is only going to be submitted for devel (where rawhide has
2.6.20-rc).  And a requires on a "new" kernel isn't the answer as a user can
trivially build the module if they really don't want to bump versions.  Also,
the requires doesn't mean that the user is actually running said kernel.

The more right answer is that as tools get built up, they need to check and make
sure the kernel provides the functionality, much like tools for xen need to
ensure that they're running on a Xen dom0.

> Also static libraries need FESCO approval. So I request you to ask FESCO for
> permission to include .a files ot drop -devel package.

I don't think that's actually been fully passed yet, but I don't care enough to
keep the library around for now.  Nuking -devel.


http://people.redhat.com/~katzj/kvm/kvm-7-3.src.rpm and
http://people.redhat.com/~katzj/kvm/kvm.spec updated

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.