[Bug 218020] Review Request: postgrey - Postfix Greylisting Policy Server

bugzilla at redhat.com bugzilla at redhat.com
Sat Dec 23 16:39:45 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postgrey - Postfix Greylisting Policy Server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218020





------- Additional Comments From tmz at pobox.com  2006-12-23 11:39 EST -------
Two other minor points that were brought up in the other postgrey review by
Michael Fleming:

1) The preferred BuildRoot tag is
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

I'm sure there are some folks that would be bothered by this.  I'm not, but it
can't hurt to follow the guidelines.

2) The empty postgrey_whitelist_clients.local.  I noticed this in the rpmlint
output and thought it seemed okay to ignore, but perhaps a better solution is to
add a comment to the file instead of just creating an empty file.

echo "# Local clients that should not be greylisted.  See postgrey(8)." \
    > %{buildroot}%{confdir}/postgrey_whitelist_clients.local

A note on this file in README-rpm might also be warranted.

Sorry for not mentioning these things on the first pass.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list