[Bug 219610] Review Request: uncrustify-0.30 - code beautifier
bugzilla at redhat.com
bugzilla at redhat.com
Tue Dec 26 04:20:06 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: uncrustify-0.30 - code beautifier
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219610
ed at eh3.com changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From ed at eh3.com 2006-12-25 23:19 EST -------
$ sha1sum uncrustify-0.30-1.fc6.src.rpm
d4a0326889cd994e29422723fd9be1517e41edc8 uncrustify-0.30-1.fc6.src.rpm
good:
+ builds in mock for FC6 i386
+ rpmlint is silent
+ license is OK and correctly included
+ spec is very simple and clean
+ no shared libs and no *.la
+ perms and dir ownership OK
+ %clean OK
could be improved:
- the "Summary: Reformat source" line is a little ambiguous and it
might be more helpful to say "Tool for source code reformatting"
or similar -- but that's just a suggestion, not a blocker
Its unfortunate how the config files are handled but I agree that it
is an upstream problem.
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list