[Bug 220743] Review Request: postgis - Geographic Information Systems Extensions to PostgreSQL

bugzilla at redhat.com bugzilla at redhat.com
Tue Dec 26 12:49:37 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postgis - Geographic Information Systems Extensions to PostgreSQL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220743





------- Additional Comments From devrim at commandprompt.com  2006-12-26 07:49 EST -------
Hi,

(In reply to comment #1)
> Review for release 1:
<snip>
> Needs work:
> * BuildRoot should be
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
>   (wiki: PackagingGuidelines#BuildRoot)

Ok, fixed.

> * Spec file: some paths are not replaced with RPM macros
>   (wiki: QAChecklist item 7)

Oops, fixed. Please let me know if I'm still missing one.

> Minor:
> * Duplicate BuildRequires: jpackage-utils (by ant), ant (by ant-junit), junit
(by ant-junit)

Very good catch. This is fixed, too.

Spec URL: http://developer.postgresql.org/~devrim/rpms/other/postgis/postgis.spec
SRPM URL:
http://developer.postgresql.org/~devrim/rpms/other/postgis/postgis-1.2.0-2.src.rpm


Thanks for the review.

Regards, Devrim



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list