[Bug 220969] Review Request: isomaster - GUI CD image editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: isomaster - GUI CD image editor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220969





------- Additional Comments From mszpak at wp.pl  2006-12-29 16:44 EST -------
(In reply to comment #1)
> Hi! Nice to see that another Pole wants to put his package in Extras! :-)
> However there's a lot to do in your spec file.

No-one is perfect ;)

>  * First of all mock build of your package fails due to a simple mistake. You
> put desktop-file-utils as Requires but it should be BuildRequires.

I moved it there due to:

desktop-file-install --vendor fedora \
    --dir %{buildroot}%{_datadir}/applications \
    %{name}.desktop

in %install section. But If mock doesn't like it I moved it back to BuildRequires.

>  * Your %files section doesn't look good. Package owns files in
> %{_datadir}/%{name}/icons/ but doesn't own the parent one. It means that if
> you remove RPM, all files within %{_datadir}/%{name}/icons/ will be deleted 
> but the dir remains. In order to fix it you ought to simply remove all
> %{_datadir}/%{name}/icons/ lines and replace them with a simple
> %{_datadir}/%{name}

Indeed. I missed it bacause I usually update my packages rather than remove :)

>  * I don't see it as a blocker but in my opinion much better solution would be
> if you move a desktop file to another Source instead of creating it in spec.
> That should be a lot more legible.

Ok, I moved it.

> And the last thing: SPEC files are different at the URL you passed here and
> inside SRPM. I hope you'll get rid of that issue in next release ;-)

This time I did my best to not update descriptions at the last moment :)


Thanks for you suggestions. 0.6-3 is ready for a review:
http://timeoff.wsisiz.edu.pl/zrzut/isomaster.spec
http://timeoff.wsisiz.edu.pl/zrzut/isomaster-0.6-3.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.