[Bug 221010] Review Request: librfid - Free Software RFID library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: librfid - Free Software RFID library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221010


bdpepple at ameritech.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From bdpepple at ameritech.net  2006-12-30 14:25 EST -------
MD5Sum:
695e7f30f570a08407e42ed278ca2fe3  librfid-0.1.0.tar.bz2

Good:
* Source URL is canonical.
* License field in spec, match tarball license.
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros.
* All necessary BuildRequires listed.
* Files have appropriate permissions and owners.
* Package name conforms to the Fedora Naming Guidelines.
* rpmlint produces no errors.
* Package builds in Mock fine.
* Package install and uninstalls cleanly on FC6.

Minor:
* I really don't think you need to add the same docs that are in the main
package to the devel package.  This isn't a blocker, but I would drop them.

+1 APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.