[Bug 199254] Review Request: perl-perlmenu

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-perlmenu


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199254





------- Additional Comments From steve at silug.org  2006-07-18 19:59 EST -------
Or use cpanspec, which is in Extras.  (Although wow, this thing is packaged
*really* poorly.  cpanspec dies fairly spectacularly on it.)

Since that isn't going to work, here are some useful suggestions:

> Source0:       
http://mirror.gnowledge.org/cpan/authors/id/S/SK/SKUNZ/perlmenu.v%{version}.tar.gz

Don't hard-code a mirror.  Use www.cpan.org.

> install -d $RPM_BUILD_ROOT{%{perl_sitelib},%{_usrsrc}/examples/%{name}-%{version}}
> install -m 644 perlmenu.pm menuutil.pl $RPM_BUILD_ROOT%{perl_sitelib}
> %{perl_sitelib}/*

s/sitelib/vendorlib/g

I don't think %{_usrsrc} is ever an appropriate place for anything.  Try just
including "%doc examples" in your %files section.

If you "find examples -type f -exec chmod 644 {} \;" in %prep, rpm shouldn't
pick up any dependencies from the example scripts either.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.