[Bug 197739] Review Request: perl-DateTime-Event-Recurrence

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-DateTime-Event-Recurrence


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197739





------- Additional Comments From tibbs at math.uh.edu  2006-07-06 19:51 EST -------
Your two manual versioned dependencies are duplicated by unversioned
dependencies found by RPM; you will have to remove yours or filter RPM's.

Review:
* source files match upstream:
   9a08830b081a93619f4a8564063e3bf0  DateTime-Event-Recurrence-0.16.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged (0.16 12 May 2005)
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64) (with DateTime-Set and
Set-Infinite in my local repo)
* rpmlint is silent.
* noarch package, so no debuginfo.
X final provides and requires are sane:
   perl(DateTime::Event::Recurrence) = 0.16
   perl(DateTime::Set::ICal)
   perl-DateTime-Event-Recurrence = 0.16-1.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
X  perl(DateTime)
X  perl(DateTime) >= 0.27
X  perl(DateTime::Set)
X  perl(DateTime::Set) >= 0.17
   perl(DateTime::Span)
   perl(Params::Validate)
   perl(constant)
   perl(integer)
   perl(strict)
   perl(vars)
* %check is present and all tests pass:
   All tests successful.
   Files=14, Tests=195, 16 wallclock secs (15.10 cusr +  0.35 csys = 15.45 CPU)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.