[Bug 197559] Review Request: scim-chinese-standard: Chinese Linux Standard IM adapter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scim-chinese-standard: Chinese Linux Standard IM adapter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197559





------- Additional Comments From petersen at redhat.com  2006-07-07 08:19 EST -------
Thanks for uploading
http://prdownloads.sourceforge.net/clsi/scim-chinese-standard-0.0.1-0.1.src.rpm

Here are some review comments:

      - MUST: rpmlint must be run on every package. The output should be posted
in the review.

E: scim-chinese-standard description-line-too-long This is an adapter to allow
SCIM to interoperate with the Input Method specification of the Chinese Linux
Standard.
W: scim-chinese-standard mixed-use-of-spaces-and-tabs

Fixing in attachment.

      - MUST: The package must be named according to the Package Naming Guidelines.

OK

      - MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec

OK

      - MUST: The package must meet the Packaging Guidelines.

Attached spec file is reworked in Fedora format to meet the guidelines.

      - MUST: The package must be licensed with an open-source compatible
license and meet other legal requirements as defined in the legal section of
Packaging Guidelines.
      - MUST: The License field in the package spec file must match the actual
license.

I think some of the code is derived from scim, which is LGPL.
So I think the license should also be LGPL.

      - MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.

Ok.

      - MUST: The spec file must be written in American English.

Ok.

      - MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.

Please upload an updated .tar.gz file to Sourceforge.

Do not include autom4te.cache/ in the tarball.  It is 2MB. ;-)
Please use "make dist" to generate the tarball.

      - MUST: The package must successfully compile and build into binary rpms
on at least one supported architecture.

Builds file on FC5 x86_64.

      - MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of Packaging Guidelines; inclusion
of those as BuildRequires is optional. Apply common sense.

Builds ok with mock for fc5.

      - MUST: A package must own all directories that it creates.

Adding %{_libdir}/scim-1.0/IMEngine/*/

      - MUST: A package must not contain any duplicate files in the %files listing.

ok

      - MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example. Every %files section must include
a %defattr(...) line.

ok

      - MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).

ok

      - MUST: Each package must consistently use macros, as described in the
macros section of Packaging Guidelines.

ok

      - MUST: Packages must NOT contain any .la libtool archives, these should
be removed in the spec.

OK

      - SHOULD: The reviewer should test that the package builds in mock.

OK

      - SHOULD: The reviewer should test that the package functions as
described. A package should not segfault instead of running, for example.

SCIM runs okay with scim-chinese-standard installed.


A fixed spec file and tarball is at:
http://people.redhat.com/petersen/extras/scim-chinese-standard-0.0.1-0.2.src.rpm

I think these files

%{_libdir}/scim-1.0/IMEngine/standard-im.so
%{_libdir}/scim-1.0/Helper/standard-helper.so

should be named chinese-standard-*.so also to avoid confusion
with any later CJK standard, or other international standard.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.