[Bug 196740] Review Request: ogre - Object-Oriented Graphics Rendering Engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ogre - Object-Oriented Graphics Rendering Engine


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196740





------- Additional Comments From wart at kobold.org  2006-07-07 13:35 EST -------
(In reply to comment #10)
> (In reply to comment #9)

> > MUSTFIX
> > =======
> > * The 'tr' trick in Source0: is cute, but my preference is to limit
> >   macro substitutions in Source0 to simple %{name} and %{version} only.
> >   Anything more complicated (like spawning subshells) becomes
> >   harder to read.  In this case, just hard code the version string.
> 
> Erm, shouldn't that be a should fix. Nowhere in the guidelines it says use of
> macros etc is forbbiden in Source0. I know some people want to copy and paste
> the Source0 URL to wget, some people even want it to contain 0 macro's. I say
> those people should learn to use "spectool -g name.spec" which will do the macro
> expansion and cut and pasting for them, directly calling wget. -> EWONTFIX

While there are no explicit guidelines against this, I feel that it falls into
the "spec file must be legible" category.  I don't think we should have to rely
on spectool to decipher source urls.  I'm willing to live with macro
substitutions, but I think shell escapes add too much indirection.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.