[Bug 197814] Review Request: autogen

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: autogen


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197814





------- Additional Comments From bugs.michael at gmx.net  2006-07-07 15:31 EST -------
Not trivial to review due to lots of issues:

* AutoOpts licence is LGPL, not GPL!

* Run rpmlint on the binary rpms! It gives further hints.

* -devel DSO files (*.so) in non-devel package!

* -devel package is missing %defattr definition

* missing scriptlet dependencies for /sbin/ldconfig

* "INSTALL" %doc file is irrelevant to users

* /usr/include/autoopts/ is orphaned

* /usr/share/autogen is orphaned

* pkgconfig file is executable

* worrisome compiler warnings, not limited to:

putshell.c: In function 'optionPutShell':
putshell.c:203: warning: format '%1$ld' expects type 'long int', but argument 2 
has type 'uintptr_t'
putshell.c:203: warning: format '%1$lX' expects type 'long unsigned int', but ar
gument 2 has type 'uintptr_t'
guileopt.c:126: warning: format '%ld' expects type 'long int', but argument 4 ha
s type 'int'
defParse-fsm.c:395: warning: embedded '\0' in format

* /usr/share/autogen/libopts-27.1.2.tar.gz -- ???

* Error during installation and package removal
(Get better *.info scriptlets from the Wiki! Avoid the wildcards!):

install-info: excess command line argument `/usr/share/info/autogen.info.gz'

install-info: excess command line argument `/usr/share/info/autogen.info.gz'
install-info: warning: no entries found for `/usr/share/info/autogen.info-1.gz';
nothing deleted

* "Provides: libopts" should be versioned:  libopts = %{version}-%{release}

* rpmlint ~/tmp/reviews/autogen/autogen-5.8.4-2.src.rpm 
W: autogen strange-permission autogen-5.8.4.tar.bz2 0666
W: autogen rpm-buildroot-usage %prep rm -rf %{buildroot}

* The main package installs some executables into /usr/bin which have
_very_ generic names, which pollute the global namespace and which
bear a huge risk of causing collisions in the future:

-rwxr-xr-x  /usr/bin/autogen
-rwxr-xr-x  /usr/bin/columns   (!)
-rwxr-xr-x  /usr/bin/getdefs   (!)
-rwxr-xr-x  /usr/bin/xml2ag

This alone would be a blocker criterion. Upstream ought to choose more
unique names and e.g. use a proper autogen_ prefix.

* /usr/share/aclocal/liboptschk.m4 looks for a missing script.

* /usr/share/aclocal/autoopts.m4 looks for a script which is only
included in the -devel package! It is not working this way!

* autoopts-config man page is in main package, script is in -devel package!

* Section 3 API manuals are in main package instead of -devel package!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.