[Bug 191005] Review Request: glob2 - Realtime Strategy game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glob2 - Realtime Strategy game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191005





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-07-07 16:17 EST -------
Okay,

This package now is approvable. But as discussed I cannot approve it untill I
sponsor you, we have some automated scripts which check things like approved
packages actually getting imported into CVS and the likes, and until sponsored
you cannot approve. I'm looking forward to your next package

Some things to make this one perfect:
-remove -Rc param from chmod, there is nothing to _R_ecurse and begin verbose
 isn't nescesarry either as rpm already show the command with the full
 (wildcard expanded) filelist.
-remove this no longer valid comment:
"# Get the used icon on the right dir with the right name and get rid of the
unused icons"
-please put empty lines between your different changelog entries, so that the
 changlog looks like this:

%changelog
* Thu Jul 04 2006 Nikolai <brkamikaze at gmail.com>
- Fixed almost all rpmlint errors; can't figure out how to get rid of the 'no-v
- Fixed the desktop file and the icons to use more standard standards :-)

* Tue Jun 27 2006 Nikolai <brkamikaze at gmail.com>
- Added the automake14 to BuildRequires to help 'mocking' the package.

* Sun May 7 2006 Nikolai <brkamikaze at gmail.com>
- First created.





-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.