[Bug 196229] Review Request: xkeyboard-config

bugzilla at redhat.com bugzilla at redhat.com
Fri Jul 7 22:12:04 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xkeyboard-config


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196229


mharris at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO_REPORTER           |ASSIGNED
                 CC|                            |xgl-maint at redhat.com




------- Additional Comments From mharris at redhat.com  2006-07-07 18:03 EST -------
(In reply to comment #1)
> Package looks good, you'll have to add a Obsoletes: xorg-x11-xkbdata and
> Provides xorg-x11-xkbdata for upgrade paths.

Yep to both.

> Can we get rid if the "super ugly hack" in %pre now?

My comment in there suggests so, but I'll need to review all possible
upgrade paths to be sure.  I like to err on the side of caution though.
A quick cursory look appears that I should be able to remove that
ugliness though.  Sometimes I put hacks of that nature in to prevent
short term developmental upgrade problems from causing unnecessary
bug reports - but later after an OS release is out, and there are unlikely
to be any (or many) people who would have gotten bitten by a development
only transient issue, it makes sense to flush the toilet so to speak. ;)


> I'm going to approve.

Cool.  I'm going to create the new package now, import it and update
the report when I'm done.  Thanks Jesse.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list