[Bug 193867] Review Request: klamav - Clam Anti-Virus on the KDE Desktop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: klamav - Clam Anti-Virus on the KDE Desktop


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193867





------- Additional Comments From cgoorah at yahoo.com.au  2006-07-11 06:17 EST -------
It looks good to me, but however the following needs to be solved:

1.
ERROR   0001: file '/usr/bin/klamav' contains a standard rpath '/usr/lib' in
[/usr/lib:/usr/lib/qt-3.3/lib]
error: Bad exit status from /var/tmp/rpm-tmp.9887 (%install)

You have a rpath error, you solve this add --disable-rpath in %configure

2.
your package is a gui, and hence you need to install the .desktop properly in
the menus:

see http://fedoraproject.org/wiki/Packaging/Guidelines#desktop

here ,
desktop-file-install --vendor fedora \
    --add-category X-Fedora \
    --add-category Utilities \
    --delete-original \
    --dir ${RPM_BUILD_ROOT}%{_datadir}/applications/ \
    ${RPM_BUILD_ROOT}%{_datadir}/applnk/Utilities/%{name}.desktop
would be appropriate

then in %files it will be %{_datadir}/applications/fedora-%{name}.desktop rather
than %{_datadir}/applnk/Utilities/klamav.desktop

don't forget to add desktop-file-utils as BuildRequires

3.
you can remove %define qtdir		%(echo ${QTDIR}) and --with-qt-dir="%{qtdir}" from
%configure

4. Icons

You need to update the gtk+ icon cache as decribed here
http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d836b77c3428619c689d
though its a package for kde.

%post
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ]; then
   %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi

%postun
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ]; then
   %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi

Correct all this afterwards, Ill make a full review and approved it if needed :)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.