[Bug 189400] Review Request: em8300(-kmod) - Hollywood+/DXR3 hardware MPEG decoder drivers and tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: em8300(-kmod) - Hollywood+/DXR3 hardware MPEG decoder drivers and tools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189400





------- Additional Comments From fedora at leemhuis.info  2006-07-11 14:20 EST -------
== General ==

Review without appropriate hardware to test, but I'm sure it'll work.

>These packages provide drivers and utilities for Sigma Designs Hollywood 
> Plus/ Creative DXR3 hardware MPEG decoder cards.  The cards require a 
> microcode (firmware) blob which is not included due to redistribution
> issues

Ehh, I don't get that here. I saw a file 
 modules/em8300.uc
in the package. Is that the firmware? If yes: why it is included? At least there
is a file 
 em8300-nofirmware-0.15.3.tar.gz
on
 http://sourceforge.net/project/showfiles.php?group_id=5165&package_id=5202
and it's missing exactly that file. But from the docs it look like a file
"em8300.bin" needs to contain the firmware.
/me confused

> but can be extracted from vendor provided Windows drivers using the tools in
the em8300-devel package, or >downloaded from the upstream project site at 

Is there a good reason why it needs to be in the devel package? It's not the
obvious place where I would look out for it.

== em8300 ==

rpmlint:

SRPM:
no output

RPM:
W: em8300-devel no-documentation
-> can be ignored

* download of Source0 doesn't work -- seems to be a sourceforge problem afaics
* Open-Source-License (GPL)
* Source matches upstream
* package is named according to the guidelines
* builds in mock on ix86-FC5
* Is there a reason why the devel package doesn't require the base package?
* "Requires:       kmod-em8300 = %{version}" is wrong -- it needs to be 
  "Requires:       em8300-kmod >= %{version}"
 
== em8300-kmod ==

rpmlint:

SRPM:
W: em8300-kmod mixed-use-of-spaces-and-tabs
-> Might be a good idea to fix that in the longer term

RPMS:
W: kmod-em8300 summary-not-capitalized em8300 kernel module(s)
-> This is probably the right thing in this case

W: kmod-em8300 unstripped-binary-or-object
/lib/modules/2.6.17-1.2139_FC5/extra/em8300/adv717x.ko
W: kmod-em8300 unstripped-binary-or-object
/lib/modules/2.6.17-1.2139_FC5/extra/em8300/bt865.ko
W: kmod-em8300 unstripped-binary-or-object
/lib/modules/2.6.17-1.2139_FC5/extra/em8300/em8300.ko
-> they get stripped during build. Hmmm, this looks like a problem in rpm. Could
you look into this?

W: kmod-em8300 no-documentation
-> expected behaviour for kmod-packages

Review:
* package is named according to the guidelines
* Open-Source-License (GPL)
* Source matches upstream
* builds in mock on ix86-FC5
* download of Source0  doesn't work -- seems to be a sourceforge problem afaics

Probably needs fixing: 
- The module isn't build for smp-kernels on ppc. Please fix if there isn't a
good reason not to do so.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.