[Bug 198285] Review Request: python-simplejson - Simple, fast, extensible JSON encoder/decoder for Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-simplejson - Simple, fast, extensible JSON encoder/decoder for Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198285


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tibbs at math.uh.edu




------- Additional Comments From tibbs at math.uh.edu  2006-07-11 18:51 EST -------
I'm not terribly well-versed in Python, but this looks to violate the guidelines:

Python packages that use setuptools need to add python-setuptools as a
BuildRequires and must either add --single-version-externally-managed to the
line invoking setup.py in %install, or must add a .pth file containing the path
to the egg or egg directory to %{python_sitelib}.

I don't believe either of those are being done.  In addition:

E: python-simplejson zero-length
/usr/lib/python2.4/site-packages/simplejson-1.3-py2.4.egg-info/zip-safe

In general the packaging here looks odd.  Why is the test suite included in the
installed module, but not called at all by a %check section in the spec?  What
about the contents of
/usr/lib/python2.4/site-packages/simplejson-1.3-py2.4.egg-info?  Shouldn't this
all be %doc, if it must be installed at all?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.