[Bug 179758] Review Request: Eiciel (ACL editor) [Seeking Sponsor]

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Eiciel (ACL editor) [Seeking Sponsor]


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=179758


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |paul at city-fan.org
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2006-07-12 13:18 EST -------
Review:

- rpmlint clean
- package and spec file naming OK
- package meets guidelines
- license is GPL, matches spec, text included
- spec file written in English and is quite legible
- sources match upstream
- package builds OK on FC5(i386) and in mock for rawhide(i386)
- buildreqs OK, but could be trimmed
- locales handled properly
- no shared libraries in default paths
- not relocatable
- no directory ownership or permissions issues
- %clean section present and correct
- macro usage is consistent, apart from a couple of commented-out lines,
  which should probably be dropped from the spec
- code, not content
- docs OK
- no devel files to consider
- no subpackages to consider
- no libtool archives
- desktop file installed properly
- no scriptlets

Needswork:

- The full contents of the NEWS file is "Refer to ChangeLog"
  There is no point packaging this file.
- Duplicate files: there are a number of images present in both
  %{_datadir}/%{name}/doc/C/figures and %{_datadir}/%{name}/img;
  could these be replaced with links?

Suggestions:

I agree with Comment #19 that you should try to avoid lines longer than
80 characters if possible. This helps make the spec file more legible.

You could drop the buildreqs on gnome-vfs2-devel and libattr-devel as they
are pulled in by libgnomeui-devel and libacl-devel respectively, which
would help with the line length.

I'm also seeing the issue from Comment #20 where the application is not
appearing in my menus. Running update-desktop-database doesn't fix it (no
surprise there) and I expect I'll have to log out and back in before I see
it.

Running the application manually, I'm not able to open anything, possibly due
to lack of acl support in the filesystems I'm using?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.