[Bug 193224] Review Request: streamer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: streamer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193224





------- Additional Comments From fedora at adslpipe.co.uk  2006-07-12 18:46 EST -------
(In reply to comment #19)

> - Corrected Changelog entry
> - Added wildcard in files section
> - Changed Source Package Path
> - Clean the SPEC file look
> 
> I have changed Source URL now. I will be happy if you please do review for
> x86_64 architecture.

changelog version tidy-up has silenced rpmlint

Source0: now points to correct location

$ md5sum /usr/src/redhat/SOURCES/streamer-1.1.3.tar.bz2 
ce10341fb74870e4b69fe2c778cd17b1  /usr/src/redhat/SOURCES/streamer-1.1.3.tar.bz2

$ wget  http://people.redhat.com/pnemade/streamer/streamer-1.1.3.tar.bz2
$ md5sum /tmp/streamer-1.1.3.tar.bz2 
ce10341fb74870e4b69fe2c778cd17b1  /tmp/streamer-1.1.3.tar.bz2

srpm is built from the specified source file

installed http://people.redhat.com/pnemade/streamer/streamer-1.1.3-2.fc5.src.rpm
on x86_64 FC5+updates

compiler spits out a few 64bit related warnings (mainly %llx format strings in
printf expecting, but not receiving long long arguments)

libng/plugins/read-avi.c: In function 'avi_add_movi':
libng/plugins/read-avi.c:66: warning: format '%llx' expects type 'long long
unsigned int', but argument 6 has type 'off_t'
libng/plugins/read-avi.c:66: warning: format '%llx' expects type 'long long
unsigned int', but argument 7 has type 'off_t'
libng/plugins/read-avi.c: In function 'avi_find_chunk':
libng/plugins/read-avi.c:216: warning: format '%llx' expects type 'long long
unsigned int', but argument 5 has type 'off_t'
libng/plugins/drv0-v4l2-old.c: In function 'xioctl':
libng/plugins/drv0-v4l2-old.c:234: warning: format '%Ld' expects type 'long long
int', but argument 11 has type 'stamp_t'

however these will probably get type promoted ok, and don't stop the build,
could be cleaned up with a patch though, at minimum casting arguments to long
long to silence the warnings.

spec file now cleaner to my eye

I've got a creative webcam pro somewhere, which has V4L1 drivers, but not V4L2
drivers from what I remember, I'll dig it out and check if the program can
actuall do any streaming ...



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.