[Bug 196146] Review Request: mod_nss

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mod_nss


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196146





------- Additional Comments From rcritten at redhat.com  2006-07-14 11:03 EST -------
Thanks for the thorough review!

The spec and SRPM files are updated.

Here are specific responses:

1. Done, added source url
2. Removed extraneous BuildRequires (left over from the httpd spec file I
initially used as a template)
3. AutoReq isn't needed, removed
4. Added quotes around $RPM_OPT_FLAGS
5. Using %configure over ./configure
6. Switched to smp_mflags
7. $DESTDIR removed fro make
8. Using appropriate macros
9. Yes, I was worried about the lib64 thing, macros make things much easier
10. Ok, removed -s from install.
11. Yes, better to have RPM own the alias dir
12. using macros instead to resolve issue
13. Using symlink as recommended 
14. Keeping cert8.db, key3.db and secmod.db is desired when the RPM is removed.
These files contain any certificates that were issued and any private key
material. One should have to be very conscious when removing these files as
certificates can be an expensive proposition.
15. Added %dir for alias directory

The only warning I see now is the dangling symlink.

Because this depends on the NSS package this file will always exist, so I think
it's relatively safe.

While it's true that mod_nss has an install target it is cleaner to do it by
hand. We are only installing a couple of files anyway. If it really causes
heartburn I can see about switching to that but most Apache modules are
installed by hand this way.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.