[Bug 193894] Review Request: ant-contrib - A collection of tasks for Ant

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ant-contrib - A collection of tasks for Ant


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193894





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-07-14 17:01 EST -------
Your SRPM indeed seems corrupt, but thats no problem since all I need in this
stage of the review is the spec.

Everything looks good now. About the classpath in the .jar. I've followed the
discusion on f-e-l and the java knowledge I once possesed is slowly coming back.
I think that the classpath in this caseis completly useless. A classpath in a
manifest is afaik to indicate that that jar needs other classes/jars loaded to
function, so refering to yourself is useless. Could you try completly removing
the classpath line from the jar and then see if things till works.

Except for the classpath issue this package is approvable. I would like us to
walk through the review of one other package before I sponsor you, which one
would you like me to review?




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.