[Bug 199029] Review Request: jokosher

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jokosher


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199029





------- Additional Comments From snecklifter at gmail.com  2006-07-17 17:55 EST -------
(In reply to comment #1)

> Also, you should not use the Packager: tag in your spec. See:
>
http://fedoraproject.org/wiki/Packaging/Guidelines#head-c17fb8c1ce9be40da720a2b25d1e2a241062038f
> 

Removed.

> Thirdly, your package would probably break on 64-bit systems, as you hardcode
> /lib/ into the path of %_pythondir. Please use a macro for this instead, such as
> %{_lib} (or %{_libdir}, etc. as needed).

Added, see below.

> 
> Forth, you really should be using %{python_sitedir} and following the %files
> section correctly as mentioned in Packaging/Python on the Wiki. See:
> http://fedoraproject.org/wiki/Packaging/Python

Done. This would appear to be one and the same with your third point.

> 
> Lastly, in the %changelog, you simply have a user at host identifier. I'm not
> certain, but I believe that this is supposed to be a full and valid email
> address (such as "me at my-isp.com" or something similar).

Done.

Thanks again for the pointers. Could you please review again and let me know if
there are any more blockers.

Regards
Chris

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.