[Bug 199491] Review Request: dbus-sharp

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dbus-sharp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199491





------- Additional Comments From paul at all-the-johnsons.co.uk  2006-07-19 16:57 EST -------
Okay, couple of comments on the install section of the spec file

# dbus installs mono files in libdir, not in prefix/lib, fixup:
perl -pi -e 's,/gacdir \$\(libdir\),/gacdir /usr/lib,g' mono/Makefile
perl -pi -e "s,/root \\\$\\(DESTDIR\\)\\\$\(libdir\\),/root
$RPM_BUILD_ROOT/usr/lib,g" mono/Makefile
perl -pi -e "s,/usr/lib64,/usr/lib,g" dbus-sharp.pc
mkdir -p $RPM_BUILD_ROOT%{_prefix}/lib/mono

make install DESTDIR=$RPM_BUILD_ROOT

I'm not sure here. If the files are being installed in %_libdir rather than
%{_prefix}/lib, why have you got the mkdir -p line? When you run the make
install, the directories are created for you by the makefile (unless in this
case, they're not of course!)

The other problem is that the .pc file is going into %_libdir/pkgconfig. I've
seen this on 64 bit architecture failing miserably, but not if it's in
%_prefix/lib (yes, I am aware of the packaging guidelines!)

The .pc file should be in a devel package by itself. Should the Source0 not
point to a URL rather than on a local machine?

You're missing the %{?dist} tag on the Release line

Finally, is the define arch required?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.